[llvm-branch-commits] [lld] [PAC][lld] Use braa instr in PAC PLT sequence with valid PAuth core info (PR #113945)

Daniil Kovalev via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Nov 1 04:24:19 PDT 2024


================
@@ -999,7 +999,9 @@ class AArch64BtiPac final : public AArch64 {
 
 private:
   bool btiHeader; // bti instruction needed in PLT Header and Entry
-  bool pacEntry;  // autia1716 instruction needed in PLT Entry
+  bool pacEntry;  // Authenticated branch needed in PLT Entry
----------------
kovdan01 wrote:

Changed to an enum, thanks! It might be worth using a switch statement instead of if's and ternary operators at the end of `AArch64BtiPac::writePlt`, but it looks like that it's readable enough right now, so I left that "as is" unless there is a request for changing that as well.

https://github.com/llvm/llvm-project/pull/113945


More information about the llvm-branch-commits mailing list