[llvm-branch-commits] [llvm] [AArch64][PAC] Lower authenticated calls with ptrauth bundles. (PR #85736)

Ahmed Bougacha via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue May 28 22:20:20 PDT 2024


ahmedbougacha wrote:

> One more overall style comment which might probably require an additional PR: sometimes identifiers use `PtrAuth`, sometimes `Ptrauth`. Is this intentional? If not, I suggest to use the same case style - it would keep things consistent and allow for case-sensitive search.

Yeah, it's hard to avoid needing case-insensitive search because of the irreconcilable capitalization rules between e.g., enums generated from all-lowercase tablegen, opcode namespaces with a strong all-uppercase tradition, variable/function naming conventions, etc.

In general I try to standardize on "ptrauth" regardless of case, and would rather get rid of "pauth" or "pac" first, because they're just objectively worse names.  We can indeed pick a consistent ptrauth when the dust settles.

https://github.com/llvm/llvm-project/pull/85736


More information about the llvm-branch-commits mailing list