[llvm-branch-commits] [mlir] [draft] Dialect Conversion without Rollback (PR #93412)

Matthias Springer via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue May 28 09:24:59 PDT 2024


================
@@ -321,15 +323,15 @@ class RandomizedWorklist : public Worklist {
 /// to the worklist in the beginning.
 class GreedyPatternRewriteDriver : public RewriterBase::Listener {
 protected:
-  explicit GreedyPatternRewriteDriver(MLIRContext *ctx,
+  explicit GreedyPatternRewriteDriver(PatternRewriter &rewriter,
                                       const FrozenRewritePatternSet &patterns,
                                       const GreedyRewriteConfig &config);
 
   /// Add the given operation to the worklist.
   void addSingleOpToWorklist(Operation *op);
 
   /// Add the given operation and its ancestors to the worklist.
-  void addToWorklist(Operation *op);
+  virtual void addToWorklist(Operation *op);
----------------
matthias-springer wrote:

We can avoid this virtual function call by templatizing the driver class.

https://github.com/llvm/llvm-project/pull/93412


More information about the llvm-branch-commits mailing list