[llvm-branch-commits] [mlir] [draft] Dialect Conversion without Rollback (PR #93412)

[Christian Ulmann via llvm-branch-commits]

https://github.com/Dinistro commented:

IIUC, this inherits from `ConversionPatternRewriter` to ensure that the conversion patterns can be used with the new `OneShotConversionPatternRewriter`. While this makes sense from a functional perspective, the introduced inheritance relation seems a bit conflicting, as the super class has supposedly more functionality than the derived class. In many practical cases, replacing usages of `ConversionPatternRewriter` with a `OneShotCovnersionPatternRewriter` might work, this is not true in the general case, right?


https://github.com/llvm/llvm-project/pull/93412