[llvm-branch-commits] [clang] [Serialization] No transitive identifier change (PR #92085)

Chuanqi Xu via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon May 27 00:34:00 PDT 2024


================
@@ -918,7 +918,7 @@ ASTSelectorLookupTrait::ReadKey(const unsigned char* d, unsigned) {
   SelectorTable &SelTable = Reader.getContext().Selectors;
   unsigned N = endian::readNext<uint16_t, llvm::endianness::little>(d);
   const IdentifierInfo *FirstII = Reader.getLocalIdentifier(
-      F, endian::readNext<uint32_t, llvm::endianness::little>(d));
+      F, endian::readNext<IdentifierID, llvm::endianness::little>(d));
----------------
ChuanqiXu9 wrote:

If `IdentifierID` is not integral type, the code can't compile (`endian::readNext` won't accept that). So I feel it might not be so useful.

https://github.com/llvm/llvm-project/pull/92085


More information about the llvm-branch-commits mailing list