[llvm-branch-commits] [llvm] release/18.x: [Mips] Fix missing sign extension in expansion of sub-word atomic max (#77072) (PR #84566)

Brad Smith via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Mar 19 14:03:48 PDT 2024


================
@@ -2001,8 +2225,6 @@ define i16 @test_umax_16(ptr nocapture %ptr, i16 signext %val) {
 ; MIPSELR6-NEXT:  $BB6_1: # %entry
 ; MIPSELR6-NEXT:    # =>This Inner Loop Header: Depth=1
 ; MIPSELR6-NEXT:    ll $2, 0($6)
-; MIPSELR6-NEXT:    and $2, $2, $8
----------------
brad0 wrote:

> @brad0 I think I missed this in the previous review. Why is it ok to remove the AND from the unsigned tests? My original command about the AND being unnecssary was for the signed cases.

Looking at the PR I am not sure that was clear and @yingopq might have interpreted your comment as to remove all together.

https://github.com/llvm/llvm-project/pull/84566


More information about the llvm-branch-commits mailing list