[llvm-branch-commits] [mlir] [mlir][IR] Add listener notifications for pattern begin/end (PR #84131)
    Mehdi Amini via llvm-branch-commits 
    llvm-branch-commits at lists.llvm.org
       
    Thu Mar  7 22:45:47 PST 2024
    
    
  
================
@@ -68,9 +68,9 @@ class PatternApplicator {
   ///            invalidate the match and try another pattern.
   LogicalResult
   matchAndRewrite(Operation *op, PatternRewriter &rewriter,
-                  function_ref<bool(const Pattern &)> canApply = {},
-                  function_ref<void(const Pattern &)> onFailure = {},
-                  function_ref<LogicalResult(const Pattern &)> onSuccess = {});
+                  std::function<bool(const Pattern &)> canApply = {},
+                  std::function<void(const Pattern &)> onFailure = {},
+                  std::function<LogicalResult(const Pattern &)> onSuccess = {});
----------------
joker-eph wrote:
That can explain why you changed it at the call-site, but I'm puzzled about this function: it does not capture the callback as far as I can tell.
https://github.com/llvm/llvm-project/pull/84131
    
    
More information about the llvm-branch-commits
mailing list