[llvm-branch-commits] [NFC] [hwasan] also be more consistent when getting pointer types (PR #84399)
via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Mar 7 15:18:33 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-transforms
Author: Florian Mayer (fmayer)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/84399.diff
1 Files Affected:
- (modified) llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp (+2-6)
``````````diff
diff --git a/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp b/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
index 289183ecf0f286..61d54b850374e1 100644
--- a/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
+++ b/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
@@ -410,8 +410,8 @@ class HWAddressSanitizer {
ShadowMapping Mapping;
Type *VoidTy = Type::getVoidTy(M.getContext());
- Type *IntptrTy;
- PointerType *PtrTy;
+ Type *IntptrTy = M.getDataLayout().getIntPtrType(M.getContext());
+ PointerType *PtrTy = PointerType::get(M.getContext(), /* AddressSpace= */0);
Type *Int8Ty = Type::getInt8Ty(M.getContext());
Type *Int32Ty = Type::getInt32Ty(M.getContext());
Type *Int64Ty = Type::getInt64Ty(M.getContext());
@@ -594,8 +594,6 @@ void HWAddressSanitizer::createHwasanCtorComdat() {
/// inserts a call to __hwasan_init to the module's constructor list.
void HWAddressSanitizer::initializeModule() {
LLVM_DEBUG(dbgs() << "Init " << M.getName() << "\n");
- auto &DL = M.getDataLayout();
-
TargetTriple = Triple(M.getTargetTriple());
// x86_64 currently has two modes:
@@ -613,8 +611,6 @@ void HWAddressSanitizer::initializeModule() {
C = &(M.getContext());
IRBuilder<> IRB(*C);
- IntptrTy = IRB.getIntPtrTy(DL);
- PtrTy = IRB.getPtrTy();
HwasanCtorFunction = nullptr;
``````````
</details>
https://github.com/llvm/llvm-project/pull/84399
More information about the llvm-branch-commits
mailing list