[llvm-branch-commits] [OpenMP][MLIR] Add new arguments to map_info to help support record type maps (PR #82851)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Mar 5 10:39:26 PST 2024


agozillon wrote:

> Is the `ptr_and_obj` modifier connected to the new arguments?

Connected to the overall PR, I should alter the description to change that. Or perhaps simplify the stack by moving the changes into a seperate PR (my original thought was that it would add more dependencies to the PR stack, but I'm not necessarily against that if it makes things easier to review). Do let me know which you'd prefer though!

The main goal is to move the setting of the `ptr_and_obj` modifier to the frontend, rather than the backend which would allow us to set it more accurately (it should only be set when necessary but currently we assume all members need the flag in lowering as we do not have the information to indicate if it is necessary, this is only correct for the descriptor base addresses or other pointer members), it's primarily used when mapping declare target/descriptor base addresses currently so unfortunately making this change means some minor alterations to these are mixed into the PR stack (moving the setting of the `ptr_and_obj` bits essentially)

https://github.com/llvm/llvm-project/pull/82851


More information about the llvm-branch-commits mailing list