[llvm-branch-commits] [mlir] [mlir][Transforms] Add listener support to dialect conversion (PR #83425)

[Jacques Pienaar via llvm-branch-commits]

https://github.com/jpienaar approved this pull request.



> *[Reviewable](https://reviewable.io/reviews/llvm/llvm-project/83425)* status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @ftynse, @joker-eph, and @matthias-springer)

___
*[`mlir/lib/Transforms/Utils/DialectConversion.cpp` line 363 at r1](https://reviewable.io/reviews/llvm/llvm-project/83425#-Ns3aO9h2L3R0Ul-IX4T:-Ns3aO9h2L3R0Ul-IX4U:blphauh) ([raw file](https://github.com/llvm/llvm-project/blob/22e8d5ea80b74d687c3e792c512f50b9de81f489/mlir/lib/Transforms/Utils/DialectConversion.cpp#L363)):*
> ```cpp
>       // notification and iterators into past IR state cannot be represented.
>       listener->notifyBlockInserted(block, /*previous=*/region,
>                                     /*previousIt=*/{});
> ```

And this is expected in the consumer that it may get not previousIt?


<!-- Sent from Reviewable.io -->


https://github.com/llvm/llvm-project/pull/83425