[llvm-branch-commits] [clang] [clang][test] add testing for the AST matcher reference (PR #94248)

Aaron Ballman via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Jun 27 11:33:52 PDT 2024


https://github.com/AaronBallman commented:

The changes generally LGTM, though I would appreciate a second set of eyes on the CMake and Python changes because I have a bit less confidence in my review abilities there.

Thank you for adding the documentation to the header file, I think that will help folks when working on their own matchers.

One question I have is: do you happen to know how this impacts build times for Clang itself? I'm assuming that if ASTMatchers.h isn't modified, CMake won't re-run `generate_ast_matcher_doc_tests.py` and so the compile time performance hit is only on full rebuilds or when changing the header?

https://github.com/llvm/llvm-project/pull/94248


More information about the llvm-branch-commits mailing list