[llvm-branch-commits] [clang] [serialization] No transitive type change (PR #92511)
Ilya Biryukov via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed Jun 19 09:55:29 PDT 2024
================
@@ -3262,17 +3262,18 @@ void ASTWriter::WritePragmaDiagnosticMappings(const DiagnosticsEngine &Diag,
/// Write the representation of a type to the AST stream.
void ASTWriter::WriteType(QualType T) {
TypeIdx &IdxRef = TypeIdxs[T];
- if (IdxRef.getIndex() == 0) // we haven't seen this type before.
+ if (IdxRef.getValue() == 0) // we haven't seen this type before.
----------------
ilya-biryukov wrote:
NIT: For the purpose of improving readability, I wonder if there is a better name than `getValue`? Would something like `getSerializedValue()` or `getGlobalIndex()` be appropriate here?
https://github.com/llvm/llvm-project/pull/92511
More information about the llvm-branch-commits
mailing list