[llvm-branch-commits] [clang] [clang] Implement function pointer signing and authenticated function calls (PR #93906)

Daniil Kovalev via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Jun 17 08:01:13 PDT 2024


================
@@ -61,3 +79,28 @@ CodeGen::getConstantSignedPointer(CodeGenModule &CGM, llvm::Constant *Pointer,
   return CGM.getConstantSignedPointer(Pointer, Key, StorageAddress,
                                       OtherDiscriminator);
 }
+
+/// If applicable, sign a given constant function pointer with the ABI rules for
----------------
kovdan01 wrote:

Do we need this comments? In CodeGenModule.h, we already have more detailed description. It looks like that other member functions of `CodeGenModule` only contain description in the header, but not in the sources, and there is probably no reason for such duplication when adding new member functions.

https://github.com/llvm/llvm-project/pull/93906


More information about the llvm-branch-commits mailing list