[llvm-branch-commits] [llvm] [BOLT] Drop high discrepancy profiles in matching (PR #95156)

shaw young via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sun Jun 16 14:08:48 PDT 2024


================
@@ -394,7 +400,7 @@ createFlowFunction(const BinaryFunction::BasicBlockOrderType &BlockOrder) {
 void matchWeightsByHashes(BinaryContext &BC,
                           const BinaryFunction::BasicBlockOrderType &BlockOrder,
                           const yaml::bolt::BinaryFunctionProfile &YamlBF,
-                          FlowFunction &Func) {
+                          FlowFunction &Func, uint64_t &MatchedBlocksCount) {
----------------
shawbyoung wrote:

In the case that we want to build upon our profile discrepancy heuristic, I think it makes sense to pass in a reference to "something" (variable, struct) that maintains information related to the heuristic, similarly how to the flow function is treated by this function. But I don't have strong feelings about this - if you do I'm happy to change it. 

https://github.com/llvm/llvm-project/pull/95156


More information about the llvm-branch-commits mailing list