[llvm-branch-commits] [llvm] [Support] Integrate SipHash.cpp into libSupport. (PR #94394)

Ahmed Bougacha via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Jun 13 15:07:36 PDT 2024


ahmedbougacha wrote:

[37c84b9](https://github.com/llvm/llvm-project/pull/94394/commits/37c84b9dce70f40db8a7c27b7de8232c4d10f78f) shows what I had in mind, let me know what you all think.  I added:
```
void getSipHash_2_4_64(const uint8_t *In, uint64_t InLen,
                       const uint8_t (&K)[16], uint8_t (&Out)[8]);

void getSipHash_2_4_128(const uint8_t *In, uint64_t InLen,
                        const uint8_t (&K)[16], uint8_t (&Out)[16]);
```
as the core interfaces, and mimicked the ref. test harness to reuse the same test vectors.  If this seems reasonable to yall I'm happy to extract the vectors.h file from the ref. implementation into the "Import original sources" PR – that's why I kept it open ;)

https://github.com/llvm/llvm-project/pull/94394


More information about the llvm-branch-commits mailing list