[llvm-branch-commits] [llvm] [Support] Integrate SipHash.cpp into libSupport. (PR #94394)

[Kristof Beyls via llvm-branch-commits]

kbeyls wrote:

> Yes, this doesn't have tests by itself because there's no exposed interface. It's certainly trivial to add one (which would allow using the reference test vectors).
> 
> I don't have strong arguments either way, but I figured the conservative option is to force hypothetical users to consider their use more seriously. One might argue that's not how we usually treat libSupport, so I'm happy to expose the raw function here.

I see some value in being able to test with the reference test vectors to be fully sure that the implementation really implements SipHash. But as I said above, I'm happy with merging this as is.

https://github.com/llvm/llvm-project/pull/94394