[llvm-branch-commits] [llvm] [Support] Integrate SipHash.cpp into libSupport. (PR #94394)
Kristof Beyls via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Wed Jun 12 00:18:24 PDT 2024
kbeyls wrote:
I just checked if there indeed are big-endian bots which should pick up if a different hash gets produced on a big-endian system. I guess this bot (the only bot?) would pick it up: https://lab.llvm.org/buildbot/#/builders/231
I now also realize that there are no tests with this commit. I assume that later commits that test hash computation for a pointer authentication discriminator will implicitly test this. In the ideal world, it seems there should be a simple test, e.g. checking one 64 bit and one 128 bit hash as part of this commit?
I don't think not having the test should block landing this PR, but if it would be straightforward to add a test, then I think it is still worthwhile to do it as part of this PR.
https://github.com/llvm/llvm-project/pull/94394
More information about the llvm-branch-commits
mailing list