[llvm-branch-commits] [clang] [clang] Define ptrauth_sign_constant builtin. (PR #93904)
Daniil Kovalev via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Mon Jun 10 07:52:56 PDT 2024
================
@@ -2030,8 +2030,25 @@ bool Sema::checkConstantPointerAuthKey(Expr *Arg, unsigned &Result) {
return false;
}
+static std::pair<const ValueDecl *, CharUnits>
+findConstantBaseAndOffset(Sema &S, Expr *E) {
+ // Must evaluate as a pointer.
+ Expr::EvalResult Result;
+ if (!E->EvaluateAsRValue(Result, S.Context) || !Result.Val.isLValue())
+ return std::make_pair(nullptr, CharUnits());
----------------
kovdan01 wrote:
Feel free to ignore: use of `std::make_pair` is not required in this context, so you can just write the following:
```suggestion
return {nullptr, CharUnits()};
```
Also applies to a couple of usages of `std::make_pair` below.
https://github.com/llvm/llvm-project/pull/93904
More information about the llvm-branch-commits
mailing list