[llvm-branch-commits] [clang] [clang] Define ptrauth_sign_constant builtin. (PR #93904)

[Daniil Kovalev via llvm-branch-commits]

================
@@ -1856,6 +1856,12 @@ class ConstantLValueEmitter : public ConstStmtVisitor<ConstantLValueEmitter,
   ConstantLValue VisitMaterializeTemporaryExpr(
                                          const MaterializeTemporaryExpr *E);
 
+  ConstantLValue emitPointerAuthSignConstant(const CallExpr *E);
+  llvm::Constant *emitPointerAuthPointer(const Expr *E);
+  unsigned emitPointerAuthKey(const Expr *E);
+  std::pair<llvm::Constant*, llvm::Constant*>
----------------
kovdan01 wrote:

>From the function prototype, it's unclear that the first element of the pair stands for `StorageAddress` and the second one - for `OtherDiscriminator`. Consider adding a comment or, alternatively, using a named structure instead of `std::pair` (would break `std::tie` usage though)

https://github.com/llvm/llvm-project/pull/93904