[llvm-branch-commits] [mlir] [MLIR][OpenMP] Clause-based OpenMP operation definition (PR #92523)

[Tom Eccles via llvm-branch-commits]

================
@@ -315,38 +266,17 @@ def SectionsOp : OpenMP_Op<"sections", [AttrSizedOperandSegments,
     into the final value, which is available in the accumulator after all the
     sections complete.
 
-    The $allocators_vars and $allocate_vars parameters are a variadic list of values
-    that specify the memory allocator to be used to obtain storage for private values.
-
-    The `nowait` attribute, when present, signifies that there should be no
-    implicit barrier at the end of the construct.
-  }];
-  let arguments = (ins Variadic<OpenMP_PointerLikeType>:$reduction_vars,
-                       OptionalAttr<SymbolRefArrayAttr>:$reductions,
-                       Variadic<AnyType>:$allocate_vars,
-                       Variadic<AnyType>:$allocators_vars,
-                       UnitAttr:$nowait);
+    The optional `byref` attribute controls whether reduction arguments are
+    passed by reference or by value.
----------------
tblah wrote:

Shouldn't this use the machinery in `OpenMP_ReductionClause`?

https://github.com/llvm/llvm-project/pull/92523