[llvm-branch-commits] [llvm] [Support] Integrate SipHash.cpp into libSupport. (PR #94394)

Kristof Beyls via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Jun 5 00:53:23 PDT 2024


https://github.com/kbeyls requested changes to this pull request.

Do I understand correctly that "remove big-endian support" results in this code not running correctly on big-endian machines?
I don't recall the LLVM project claiming that it cannot run on big-endian machines.
If I understand this correctly, I would not remove the big-endian support.
(I think it also helps with keeping the source code closer to the upstream siphash version, which might have some benefits?)

https://github.com/llvm/llvm-project/pull/94394


More information about the llvm-branch-commits mailing list