[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

Louis Dionne via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 16 08:53:17 PST 2024


================
@@ -132,13 +154,62 @@ def parseScript(test, preamble):
     script += scriptInTest
 
     # Add compile flags specified with ADDITIONAL_COMPILE_FLAGS.
+    # Modules need to be build with the same compilation flags as the
+    # test. So add these flags before adding the modules.
     substitutions = [
----------------
ldionne wrote:

Suggestion: Use `substitutions = dsl._appendToSubstitution(substitutions, "%{compile_flags}", " ".join(additionalCompileFlags))`

Same for the modules compile flags.

https://github.com/llvm/llvm-project/pull/76246


More information about the llvm-branch-commits mailing list