[llvm-branch-commits] [flang] [libc] [compiler-rt] [llvm] [lld] [clang] [libcxx] [lldb] [clang-tools-extra] [libcxxabi] [llvm-exegesis] Add support for validation counters (PR #76653)

via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Fri Jan 12 00:17:41 PST 2024


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff e3e47a15679e2df3f1b5f161164bc0fe82833583 ea146f2462c7155fc796b58bb7f7d92527e58422 -- llvm/tools/llvm-exegesis/lib/BenchmarkResult.cpp llvm/tools/llvm-exegesis/lib/BenchmarkResult.h llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.cpp llvm/tools/llvm-exegesis/lib/LatencyBenchmarkRunner.h llvm/tools/llvm-exegesis/lib/PerfHelper.cpp llvm/tools/llvm-exegesis/lib/PerfHelper.h llvm/tools/llvm-exegesis/lib/Target.cpp llvm/tools/llvm-exegesis/lib/Target.h llvm/tools/llvm-exegesis/lib/UopsBenchmarkRunner.cpp llvm/tools/llvm-exegesis/lib/UopsBenchmarkRunner.h llvm/tools/llvm-exegesis/lib/X86/Target.cpp llvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp llvm/tools/llvm-exegesis/llvm-exegesis.cpp llvm/unittests/tools/llvm-exegesis/ClusteringTest.cpp llvm/unittests/tools/llvm-exegesis/Mips/BenchmarkResultTest.cpp llvm/unittests/tools/llvm-exegesis/X86/BenchmarkResultTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/tools/llvm-exegesis/lib/PerfHelper.cpp b/llvm/tools/llvm-exegesis/lib/PerfHelper.cpp
index 8f4ce5c1f7..14738c7108 100644
--- a/llvm/tools/llvm-exegesis/lib/PerfHelper.cpp
+++ b/llvm/tools/llvm-exegesis/lib/PerfHelper.cpp
@@ -108,7 +108,7 @@ StringRef PerfEvent::getPfmEventString() const {
 }
 
 CounterGroup::CounterGroup(PerfEvent &&E, std::vector<PerfEvent> &&ValEvents,
-                 pid_t ProcessID)
+                           pid_t ProcessID)
     : Event(std::move(E)), ValidationEvents(std::move(ValEvents)),
       ValidationFDs(ValidationEvents.size(), -1) {
   assert(Event.valid());
diff --git a/llvm/tools/llvm-exegesis/lib/PerfHelper.h b/llvm/tools/llvm-exegesis/lib/PerfHelper.h
index edc56e56dd..547cf6e429 100644
--- a/llvm/tools/llvm-exegesis/lib/PerfHelper.h
+++ b/llvm/tools/llvm-exegesis/lib/PerfHelper.h
@@ -85,7 +85,7 @@ class CounterGroup {
 public:
   // event: the PerfEvent to measure.
   explicit CounterGroup(PerfEvent &&event, std::vector<PerfEvent> &&ValEvents,
-                   pid_t ProcessID = 0);
+                        pid_t ProcessID = 0);
 
   CounterGroup(const CounterGroup &) = delete;
   CounterGroup(CounterGroup &&other) = default;
diff --git a/llvm/tools/llvm-exegesis/lib/Target.cpp b/llvm/tools/llvm-exegesis/lib/Target.cpp
index 8c77ccb6a3..58cf1b96fe 100644
--- a/llvm/tools/llvm-exegesis/lib/Target.cpp
+++ b/llvm/tools/llvm-exegesis/lib/Target.cpp
@@ -56,8 +56,8 @@ ExegesisTarget::createCounter(StringRef CounterName, const LLVMState &,
               .concat("'"));
   }
 
-  return std::make_unique<pfm::CounterGroup>(std::move(Event),
-                                        std::move(ValidationEvents), ProcessID);
+  return std::make_unique<pfm::CounterGroup>(
+      std::move(Event), std::move(ValidationEvents), ProcessID);
 }
 
 void ExegesisTarget::registerTarget(ExegesisTarget *Target) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/76653


More information about the llvm-branch-commits mailing list