[llvm-branch-commits] [asan] isInterestingAlloca: remove the isAllocaPromotable condition (PR #77221)

[Vitaly Buka via llvm-branch-commits]

vitalybuka wrote:

I gues 

> > > We need to calculate StackSafetyGlobalInfo before inserting `__asan_memcpy`
> 
> Yes, but this is currently not guaranteed. This patch will ensure this property and fix the issue.

Then the correct way to fix this issue to avoid lazy getInfo().
It should be calculated at SSI = &MAM.getResult<StackSafetyGlobalAnalysis>(M);
Having analysis calculated before modifications is quite important here.

> 
> > And I would expect that neither [8ed1d81](https://github.com/llvm/llvm-project/commit/8ed1d8196bef89c3099be4ce4aa65f613ab819cc) or StackSafety should apply to -O0
> 
> @AnnaZaks for [8ed1d81](https://github.com/llvm/llvm-project/commit/8ed1d8196bef89c3099be4ce4aa65f613ab819cc) `[asan] Skip promotable allocas to improve performance at -O0`

Turning off isAllocaPromotable is LGTM,  I would probably recommend just switch opt<> default to false, and keep it just in case.

I don't see @AnnaZaks active here recently.
@yln @rsundahl instead


https://github.com/llvm/llvm-project/pull/77221