[llvm-branch-commits] [llvm] [SelectionDAG] Legalize <1 x T> vector types for atomic load (PR #120385)
James Y Knight via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Dec 19 07:42:34 PST 2024
jyknight wrote:
> At this PR, this is the expectation. A later PR needs to handle the other vector legalization cases
Well, it also doesn't work after the rest of the series.
As a general comment, I find it difficult to review a series of PRs where the intermediate state between them is broken, and without any clear indication as to what is and isn't supposed to work after each PR.
If this set of changes is going to remain split up into multiple PRs, the descriptions need to make it clear what's the expected state after each one, so I don't need to guess as to which of the PRs to leave a comment like that on...
https://github.com/llvm/llvm-project/pull/120385
More information about the llvm-branch-commits
mailing list