[llvm-branch-commits] [mlir] [mlir][Properties] Shorten "Property" to "Prop" in most places (PR #120368)

Markus Böck via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Dec 18 01:11:09 PST 2024


================
@@ -113,13 +113,13 @@ struct AttributeLikeVariable : public VariableElement {
     return isa<VariableElement>(fe) && classof(cast<VariableElement>(fe));
   }
 
-  /// Returns true if the variable is a UnitAttr or a UnitProperty.
+  /// Returns true if the variable is a UnitAttr or a UnitProp.
   bool isUnit() const {
     if (const auto *attr = dyn_cast<AttributeVariable>(this))
       return attr->getVar()->attr.getBaseAttr().getAttrDefName() == "UnitAttr";
     if (const auto *prop = dyn_cast<PropertyVariable>(this)) {
       return prop->getVar()->prop.getBaseProperty().getPropertyDefName() ==
-             "UnitProperty";
+             "UnitProp";
----------------
zero9178 wrote:

Isn't this going to fail now for `UnitProperty`?

https://github.com/llvm/llvm-project/pull/120368


More information about the llvm-branch-commits mailing list