[llvm-branch-commits] [lldb][Process] Introduce LoongArch64 hw break/watchpoint support (PR #118770)
David Spickett via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Tue Dec 10 02:09:52 PST 2024
================
@@ -58,10 +59,21 @@ NativeRegisterContextLinux_loongarch64::NativeRegisterContextLinux_loongarch64(
std::unique_ptr<RegisterInfoPOSIX_loongarch64> register_info_up)
: NativeRegisterContextRegisterInfo(native_thread,
register_info_up.release()),
- NativeRegisterContextLinux(native_thread) {
+ NativeRegisterContextLinux(native_thread),
+ NativeRegisterContextDBReg_arm64(/*CTRL_PLV3_ENABLE=*/0x10U) {
----------------
DavidSpickett wrote:
I like adding these comments but really it should be the name of the parameter in the first part. You could do:
```
/*whatever_the_parameter_name_is=*/0x10U /*CTRL_PLV3_ENABLE/*
```
This is a bit more useful and also any tool like clang-tidy that checks these comments won't complain that `CTRL_PLV3_ENABLE` isn't a prameter.
https://github.com/llvm/llvm-project/pull/118770
More information about the llvm-branch-commits
mailing list