[llvm-branch-commits] [clang] [llvm] [clang][OpenMP] Prototype #3 of directive splitting (PR #118880)

[via llvm-branch-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 1447ec21597f752b29e367a46f06eecdf9c81dd7 ba9e94076839e534f761af41442d03d53c5b40ca --extensions h,cpp -- clang/lib/Sema/SemaOpenMPExt.cpp clang/lib/Sema/SemaOpenMPExt.h clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/Stmt.h clang/include/clang/Basic/OpenMPKinds.h clang/include/clang/Sema/SemaOpenMP.h clang/lib/AST/Stmt.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/Basic/OpenMPKinds.cpp clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Parse/ParseOpenMP.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaOpenMP.cpp clang/lib/Sema/TreeTransform.h llvm/include/llvm/Frontend/OpenMP/ConstructDecompositionT.h llvm/include/llvm/Frontend/OpenMP/OMP.h llvm/lib/Frontend/OpenMP/OMP.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/clang/include/clang/Sema/SemaOpenMP.h b/clang/include/clang/Sema/SemaOpenMP.h
index 081b6154be..ecd01363fc 100644
--- a/clang/include/clang/Sema/SemaOpenMP.h
+++ b/clang/include/clang/Sema/SemaOpenMP.h
@@ -1445,9 +1445,9 @@ public:
 
     VariableImplicitInfo &include(const VariableImplicitInfo &Other);
 
-  #ifndef NDEBUG
+#ifndef NDEBUG
     bool empty() const;
-  #endif
+#endif
 
   private:
     std::pair<Stmt *, Decl *> getDecl(Expr *E);
diff --git a/clang/lib/Sema/SemaOpenMPExt.cpp b/clang/lib/Sema/SemaOpenMPExt.cpp
index a8693c65c3..45ff19b179 100644
--- a/clang/lib/Sema/SemaOpenMPExt.cpp
+++ b/clang/lib/Sema/SemaOpenMPExt.cpp
@@ -939,8 +939,7 @@ Defaultmap make(const OMPDefaultmapClause &C) {
   };
 }
 
-Doacross make(DependenceType DepType,
-              llvm::ArrayRef<const Expr *> Vars);
+Doacross make(DependenceType DepType, llvm::ArrayRef<const Expr *> Vars);
 
 Depend make(const OMPDependClause &C) {
   std::optional<Iterator> maybeIterator = tryMakeIterator(C.getModifier());
@@ -1001,12 +1000,10 @@ DistSchedule make(const OMPDistScheduleClause &C) {
   };
 }
 
-Doacross make(DependenceType DepType,
-              llvm::ArrayRef<const Expr *> Vars) {
+Doacross make(DependenceType DepType, llvm::ArrayRef<const Expr *> Vars) {
   // XXX The loop iteration distance vector is unavailable (it's not exported
   // from Sema/SemaOpenMP.
-  assert(DepType == DependenceType::Sink ||
-         DepType == DependenceType::Source);
+  assert(DepType == DependenceType::Sink || DepType == DependenceType::Source);
   return Doacross{{/*DependenceType=*/DepType, /*Vector=*/{}}};
 }
 
diff --git a/clang/lib/Sema/SemaOpenMPExt.h b/clang/lib/Sema/SemaOpenMPExt.h
index 7a36837560..148306fde5 100644
--- a/clang/lib/Sema/SemaOpenMPExt.h
+++ b/clang/lib/Sema/SemaOpenMPExt.h
@@ -310,15 +310,15 @@ auto vnoc(clause::Defaultmap::ImplicitBehavior T)
 auto vnoc(clause::Device::DeviceModifier T)
     -> clang::OpenMPDeviceClauseModifier;
 auto vnoc(clause::DistSchedule::Kind T) -> clang::OpenMPDistScheduleClauseKind;
-//auto vnoc(clause::Grainsize::Prescriptiveness T)
-//    -> clang::OpenMPGrainsizeClauseModifier;
+// auto vnoc(clause::Grainsize::Prescriptiveness T)
+//     -> clang::OpenMPGrainsizeClauseModifier;
 auto vnoc(clause::Lastprivate::LastprivateModifier T)
     -> clang::OpenMPLastprivateModifier;
 auto vnoc(clause::Linear::LinearModifier T) -> clang::OpenMPLinearClauseKind;
 auto vnoc(clause::Map::MapType T) -> clang::OpenMPMapClauseKind;
 auto vnoc(clause::Map::MapTypeModifier T) -> clang::OpenMPMapModifierKind;
-//auto vnoc(clause::NumTasks::Prescriptiveness)
-//    -> clang::OpenMPNumTasksClauseModifier;
+// auto vnoc(clause::NumTasks::Prescriptiveness)
+//     -> clang::OpenMPNumTasksClauseModifier;
 auto vnoc(clause::Order::Ordering T) -> clang::OpenMPOrderClauseKind;
 auto vnoc(clause::Order::OrderModifier T) -> clang::OpenMPOrderClauseModifier;
 auto vnoc(clause::Reduction::ReductionModifier T)
diff --git a/llvm/include/llvm/Frontend/OpenMP/ConstructDecompositionT.h b/llvm/include/llvm/Frontend/OpenMP/ConstructDecompositionT.h
index a99f52a8a1..ce856430e9 100644
--- a/llvm/include/llvm/Frontend/OpenMP/ConstructDecompositionT.h
+++ b/llvm/include/llvm/Frontend/OpenMP/ConstructDecompositionT.h
@@ -96,7 +96,8 @@ struct ConstructDecompositionT {
                           llvm::omp::Directive dir,
                           llvm::ArrayRef<ClauseTy> clauses,
                           bool makeImplicit = true)
-      : version(ver), construct(dir), makeImplicit(makeImplicit), helper(helper) {
+      : version(ver), construct(dir), makeImplicit(makeImplicit),
+        helper(helper) {
     for (const ClauseTy &clause : clauses)
       nodes.push_back(&clause);
 
@@ -253,7 +254,7 @@ private:
 
   uint32_t version;
   llvm::omp::Directive construct;
-  bool makeImplicit;   // Whether to create implicit clauses.
+  bool makeImplicit; // Whether to create implicit clauses.
   HelperType &helper;
   ListT<LeafReprInternal> leafs;
   tomp::ListT<const ClauseTy *> nodes;

``````````

</details>


https://github.com/llvm/llvm-project/pull/118880