[llvm-branch-commits] [llvm] [NFC][Utils] Extract BuildDebugInfoMDMap from CloneFunctionInto (PR #118622)

Felipe de Azevedo Piovezan via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Dec 4 08:48:24 PST 2024


================
@@ -79,14 +79,16 @@ struct ValueMapConfig {
   static mutex_type *getMutex(const ExtraDataT &/*Data*/) { return nullptr; }
 };
 
+/// This type stores Metadata. Used in ValueMap.
+using MDMapT = DenseMap<const Metadata *, TrackingMDRef>;
----------------
felipepiovezan wrote:

I don't think we should have a type alias that is an implementation detail in the `llvm::` namespace, as it adds visibility to this everywhere. We should instead move it to the public `ValueMap` API and refer to it as `ValueMap::MDMapT` (or just spell out the type completely and not worry about the typedef)

https://github.com/llvm/llvm-project/pull/118622


More information about the llvm-branch-commits mailing list