[llvm-branch-commits] [llvm] [NFC] Remove adhoc definition of MDMapT in IRMover (PR #118626)

Artem Pianykh via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Dec 4 05:15:47 PST 2024


https://github.com/artempyanykh created https://github.com/llvm/llvm-project/pull/118626

[NFC] Remove adhoc definition of MDMapT in IRMover

Summary:
The typedef was there probably because the type alias in ValueMap was private.

Test Plan:
ninja check-llvm-unit check-llvm

>From 7986937bb770f802f936b84ec4ee43729329b712 Mon Sep 17 00:00:00 2001
From: Artem Pianykh <arr at fb.com>
Date: Sun, 15 Sep 2024 02:59:24 -0700
Subject: [PATCH] [NFC] Remove adhoc definition of MDMapT in IRMover

Summary:
The typedef was there probably because the type alias in ValueMap was private.

Test Plan:
ninja check-llvm-unit check-llvm
---
 llvm/include/llvm/Linker/IRMover.h | 4 +---
 llvm/lib/Linker/IRMover.cpp        | 3 ---
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/llvm/include/llvm/Linker/IRMover.h b/llvm/include/llvm/Linker/IRMover.h
index 1e3c5394ffa2af..89e9cbe0be18e1 100644
--- a/llvm/include/llvm/Linker/IRMover.h
+++ b/llvm/include/llvm/Linker/IRMover.h
@@ -12,6 +12,7 @@
 #include "llvm/ADT/ArrayRef.h"
 #include "llvm/ADT/DenseSet.h"
 #include "llvm/ADT/FunctionExtras.h"
+#include "llvm/IR/ValueMap.h"
 #include <functional>
 
 namespace llvm {
@@ -41,9 +42,6 @@ class IRMover {
     static bool isEqual(const StructType *LHS, const StructType *RHS);
   };
 
-  /// Type of the Metadata map in \a ValueToValueMapTy.
-  typedef DenseMap<const Metadata *, TrackingMDRef> MDMapT;
-
 public:
   class IdentifiedStructTypeSet {
     // The set of opaque types is the composite module.
diff --git a/llvm/lib/Linker/IRMover.cpp b/llvm/lib/Linker/IRMover.cpp
index a0c3f2c5b0baf6..76af83df00cba2 100644
--- a/llvm/lib/Linker/IRMover.cpp
+++ b/llvm/lib/Linker/IRMover.cpp
@@ -373,9 +373,6 @@ class LocalValueMaterializer final : public ValueMaterializer {
   Value *materialize(Value *V) override;
 };
 
-/// Type of the Metadata map in \a ValueToValueMapTy.
-typedef DenseMap<const Metadata *, TrackingMDRef> MDMapT;
-
 /// This is responsible for keeping track of the state used for moving data
 /// from SrcM to DstM.
 class IRLinker {



More information about the llvm-branch-commits mailing list