[llvm-branch-commits] [llvm] DAG: Handle lowering unordered compare with inf (PR #100378)

Serge Pavlov via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Aug 28 06:22:08 PDT 2024


================
@@ -219,9 +219,13 @@ findSplitPointForStackProtector(MachineBasicBlock *BB,
 /// (i.e. fewer instructions should be required to lower it).  An example is the
 /// test "inf|normal|subnormal|zero", which is an inversion of "nan".
 /// \param Test The test as specified in 'is_fpclass' intrinsic invocation.
+///
+/// \param UseFP The intention is to perform the comparison using floating-point
+/// compare instructions which check for nan.
+///
----------------
spavloff wrote:

In the example in https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments parameter lines are not separated by blank lines.

It is not a big deal, but the params separated from each other and NOT separated from the description didn't look good.

https://github.com/llvm/llvm-project/pull/100378


More information about the llvm-branch-commits mailing list