[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

[Vassil Vassilev via llvm-branch-commits]

================
@@ -1827,6 +1833,12 @@ void ASTDeclWriter::VisitVarTemplateDecl(VarTemplateDecl *D) {
 
 void ASTDeclWriter::VisitVarTemplateSpecializationDecl(
     VarTemplateSpecializationDecl *D) {
+  // FIXME: We need to load the "logical" first declaration before writing
+  // the Redeclarable part. But it may be too expensive to load all the
+  // specializations. Maybe we can find a way to load the "logical" first
+  // declaration only. Or we should try to solve this on the reader side.
----------------
vgvassilev wrote:

I am not too concerned about this. A cheap read operation is much more important than a cheap write operation. I think loading all specializations before writing is fine. Although I am not sure if we should do it here or when writing the template decl itself.

https://github.com/llvm/llvm-project/pull/83237