[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Make materializations optional (PR #104668)

Markus Böck via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Aug 19 13:00:14 PDT 2024


https://github.com/zero9178 approved this pull request.

LGTM

Slight nit in the PR description: Initially reading paragraph one and two had me confused whether the `ConversionConfig::buildMaterializations` knob and the "automatic materilization" as you called it were referring to the same thing or not. Maybe merging these two paragraphs would make this clearer.

https://github.com/llvm/llvm-project/pull/104668


More information about the llvm-branch-commits mailing list