[llvm-branch-commits] [llvm] AMDGPU/NewPM: Fill out passes in addCodeGenPrepare (PR #102867)

Arthur Eubanks via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon Aug 12 12:40:13 PDT 2024


================
@@ -106,3 +135,12 @@ Error AMDGPUCodeGenPassBuilder::addInstSelector(AddMachinePass &addPass) const {
   addPass(SILowerI1CopiesPass());
   return Error::success();
 }
+
+bool AMDGPUCodeGenPassBuilder::isPassEnabled(const cl::opt<bool> &Opt,
----------------
aeubanks wrote:

is this pattern specific to AMDGPU? perhaps it should go in a more general place

also in general, is it necessary to have so many flags that force enable/disable passes? e.g. the middle-end optimizer doesn't have so many flags that force enable/disable passes

https://github.com/llvm/llvm-project/pull/102867


More information about the llvm-branch-commits mailing list