[llvm-branch-commits] [MC][profgen][NFC] Expand auto for MCDecodedPseudoProbe (PR #102788)

Amir Ayupov via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Sat Aug 10 23:24:55 PDT 2024


================
@@ -657,7 +657,7 @@ MCPseudoProbeDecoder::getCallProbeForAddr(uint64_t Address) const {
   const auto &Probes = It->second;
 
   const MCDecodedPseudoProbe *CallProbe = nullptr;
-  for (const auto &Probe : Probes) {
----------------
aaupov wrote:

> Ok, then this change should be part of #102789, and should not be separated. Otherwise the motivation and effect of this change is lost, because the base side of this change still use `std::list`, and the change description stating "trigger type casts" can be confusing.
> 
> Suggest you merge it back (or at least fix change description).

I intended to minimize the changes in #102789 and make all preparation changes small, isolated, and verifiably NFC. I've changed the description, hope it makes sense now.

https://github.com/llvm/llvm-project/pull/102788


More information about the llvm-branch-commits mailing list