[llvm-branch-commits] [flang] [mlir] [OpenMP][MLIR] Set omp.composite attr for composite loop wrappers and add verifier checks (PR #102341)

Sergio Afonso via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Thu Aug 8 03:03:24 PDT 2024


https://github.com/skatrak commented:

Thank you for picking up this work. In general it looks good, but apart from some nits I think some improvements can be made to the op verifiers as well.

Also, please update mlir/test/Dialect/OpenMP/ops.mlir to add the `omp.composite` attribute to all ops representing a composite construct, as well as adding test cases to mlir/test/Dialect/OpenMP/invalid.mlir to test each of the new error cases.

https://github.com/llvm/llvm-project/pull/102341


More information about the llvm-branch-commits mailing list