[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

[Ilya Biryukov via llvm-branch-commits]

ilya-biryukov wrote:

We've hit an error during testing:
```cpp
In module '...stl_cc_library':
.../src/libcxx/include/__memory/allocator.h:128:60: error: 'std::allocator<std::pair<const std::string, std::string>>::deallocate' from module '...stl_cc_library./cxx17/vector' is not present in definition of 'std::allocator<std::pair<const std::string, std::string>>' provided earlier
  128 |   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void deallocate(_Tp* __p, size_t __n) _NOEXCEPT {
      |                                                            ^
.../src/libcxx/include/__memory/allocator.h:94:28: note: definition has no member 'deallocate'
   94 | class _LIBCPP_TEMPLATE_VIS allocator : private __non_trivial_if<!is_void<_Tp>::value, allocator<_Tp> > {
      |                            ^

```

I will try to share a reproducer, but just like the last time, this might take quite some time because it only shows up with code that builds many modules before eventually producing this error.

https://github.com/llvm/llvm-project/pull/83237