[llvm-branch-commits] [flang] [llvm] [clang-tools-extra] [clang] [compiler-rt] [libc] [OptTable] Make new lines in help text respect indentation (PR #74880)
James Henderson via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Tue Dec 12 00:37:29 PST 2023
https://github.com/jh7370 commented:
> > Is the main functionality of this test actually tested in the current patch? It doesn't seem to be to me.
> I don't fully understand your comment, I am working on getting some of the test to be whitespace strict to specifically test the functionality.
I just didn't see any testing like you've now added in OptionParsingTest.cpp that showed that the indentation was working correctly as desired.
Taking a step back, I'm not sure the addition of the dash has anything to do with the main purpose of this PR, and I'm a little worried people will not spot that this PR is adding it. I personally have no issue with that part of the change, but I wonder if others wouldn't want it?
https://github.com/llvm/llvm-project/pull/74880
More information about the llvm-branch-commits
mailing list