[llvm-branch-commits] [clang] a52b7bf - PR50294: Fix a performance regression from 2c9dbcd.

[Tom Stellard via llvm-branch-commits]

Author: Richard Smith
Date: 2021-09-07T10:46:41-07:00
New Revision: a52b7bf7d1238bc34d5810884404993078beae01

URL: https://github.com/llvm/llvm-project/commit/a52b7bf7d1238bc34d5810884404993078beae01
DIFF: https://github.com/llvm/llvm-project/commit/a52b7bf7d1238bc34d5810884404993078beae01.diff

LOG: PR50294: Fix a performance regression from 2c9dbcd.

Per the contract of ReadLateParsedTemplates, we should not be returning
the same results multiple times. No functionality change intended, other
than to runtime.

Thanks to Luboš Luňák for identifying the cause of the regression!

(cherry picked from commit 6eda66b0a9f793c65852aa94430ae9bd891bcf63)

Added: 
    

Modified: 
    clang/lib/Serialization/ASTReader.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Serialization/ASTReader.cpp b/clang/lib/Serialization/ASTReader.cpp
index 83bade9941b3d..1722572f1a277 100644
--- a/clang/lib/Serialization/ASTReader.cpp
+++ b/clang/lib/Serialization/ASTReader.cpp
@@ -8456,6 +8456,8 @@ void ASTReader::ReadLateParsedTemplates(
       LPTMap.insert(std::make_pair(FD, std::move(LT)));
     }
   }
+
+  LateParsedTemplates.clear();
 }
 
 void ASTReader::LoadSelector(Selector Sel) {