[llvm-branch-commits] [polly] b8e4d4e - [PollyACC] Fix implicit function definitions. NFC.

Tom Stellard via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Mon May 3 17:18:26 PDT 2021


Author: Michael Kruse
Date: 2021-05-03T17:18:07-07:00
New Revision: b8e4d4eafeded48f3c07797a2d8ccc950394085e

URL: https://github.com/llvm/llvm-project/commit/b8e4d4eafeded48f3c07797a2d8ccc950394085e
DIFF: https://github.com/llvm/llvm-project/commit/b8e4d4eafeded48f3c07797a2d8ccc950394085e.diff

LOG: [PollyACC] Fix implicit function definitions. NFC.

The isl_id_* have been in used without including the correspodning
isl/id.h header. According to rules in C, a function is defined
implicitly when first used with an assumed int return type (32 bits on
64 bit systems). But the implementation returns a pointer (64 bits on 64
bit systems). Is usually has no consequence because the return value is
stored in a registers that is 64 bits (RAX) and the optimizer does not
truncate its value before using it again as a pointer value. However,
LTO optimizers will be rightfull;y confused.

Fix by including <isl/id.h>

This fixes llvm.org/PR50021

(cherry picked from commit 90e5ce0b0d6b0e72fdc034cbb612f67d67de0fdd)

Added: 
    

Modified: 
    polly/lib/External/ppcg/print.c

Removed: 
    


################################################################################
diff  --git a/polly/lib/External/ppcg/print.c b/polly/lib/External/ppcg/print.c
index 79aaf2b00d237..dd839e48e51ba 100644
--- a/polly/lib/External/ppcg/print.c
+++ b/polly/lib/External/ppcg/print.c
@@ -9,6 +9,7 @@
 
 #include <isl/aff.h>
 #include <isl/ast_build.h>
+#include <isl/id.h>
 
 #include "print.h"
 #include "util.h"


        


More information about the llvm-branch-commits mailing list