[llvm-branch-commits] [lld] 299b0e5 - [lld] Consistent help text for `--save-temps`

[Sam Clegg via llvm-branch-commits]

Author: Sam Clegg
Date: 2021-01-25T10:27:18-08:00
New Revision: 299b0e5ee9ee30093ccc9fe78b7797c16887150d

URL: https://github.com/llvm/llvm-project/commit/299b0e5ee9ee30093ccc9fe78b7797c16887150d
DIFF: https://github.com/llvm/llvm-project/commit/299b0e5ee9ee30093ccc9fe78b7797c16887150d.diff

LOG: [lld] Consistent help text for `--save-temps`

I noticed that this option was not appearing at all in the `--help`
messages for `wasm-ld` or `ld.lld`.

Add help text and make it consistent across all ports.

Differential Revision: https://reviews.llvm.org/D94925

Added: 
    

Modified: 
    lld/COFF/Options.td
    lld/ELF/Options.td
    lld/MachO/Options.td
    lld/wasm/Options.td

Removed: 
    


################################################################################
diff  --git a/lld/COFF/Options.td b/lld/COFF/Options.td
index 5447c8312128..73c3380df17c 100644
--- a/lld/COFF/Options.td
+++ b/lld/COFF/Options.td
@@ -68,7 +68,7 @@ def lldltocache : P<"lldltocache",
 def lldltocachepolicy : P<"lldltocachepolicy",
     "Pruning policy for the ThinLTO cache">;
 def lldsavetemps : F<"lldsavetemps">,
-    HelpText<"Save temporary files instead of deleting them">;
+    HelpText<"Save intermediate LTO compilation results">;
 def machine : P<"machine", "Specify target platform">;
 def merge   : P<"merge", "Combine sections">;
 def mllvm   : P<"mllvm", "Options to pass to LLVM">;

diff  --git a/lld/ELF/Options.td b/lld/ELF/Options.td
index 0ca283cdfe08..65ef3e824f50 100644
--- a/lld/ELF/Options.td
+++ b/lld/ELF/Options.td
@@ -566,7 +566,7 @@ def opt_remarks_with_hotness: FF<"opt-remarks-with-hotness">,
   HelpText<"Include hotness information in the optimization remarks file">;
 def opt_remarks_format: Separate<["--"], "opt-remarks-format">,
   HelpText<"The format used for serializing remarks (default: YAML)">;
-def save_temps: F<"save-temps">;
+def save_temps: F<"save-temps">, HelpText<"Save intermediate LTO compilation results">;
 def lto_basic_block_sections: JJ<"lto-basic-block-sections=">,
   HelpText<"Enable basic block sections for LTO">;
 defm lto_unique_basic_block_section_names: BB<"lto-unique-basic-block-section-names",

diff  --git a/lld/MachO/Options.td b/lld/MachO/Options.td
index 3410f50fa317..51c834c57238 100644
--- a/lld/MachO/Options.td
+++ b/lld/MachO/Options.td
@@ -477,7 +477,7 @@ def dependency_info : Separate<["-"], "dependency_info">,
      Flags<[HelpHidden]>,
      Group<grp_introspect>;
 def save_temps : Flag<["-"], "save-temps">,
-     HelpText<"Save temporary files instead of deleting them">,
+     HelpText<"Save intermediate LTO compilation results">,
      Group<grp_introspect>;
 
 def grp_symtab : OptionGroup<"symtab">, HelpText<"SYMBOL TABLE OPTIMIZATIONS">;

diff  --git a/lld/wasm/Options.td b/lld/wasm/Options.td
index ae5ec20d07e8..8e9ebeb168d6 100644
--- a/lld/wasm/Options.td
+++ b/lld/wasm/Options.td
@@ -214,7 +214,7 @@ def lto_O: J<"lto-O">, MetaVarName<"<opt-level>">,
 def lto_partitions: J<"lto-partitions=">,
   HelpText<"Number of LTO codegen partitions">;
 def disable_verify: F<"disable-verify">;
-def save_temps: F<"save-temps">;
+def save_temps: F<"save-temps">, HelpText<"Save intermediate LTO compilation results">;
 def thinlto_cache_dir: J<"thinlto-cache-dir=">,
   HelpText<"Path to ThinLTO cached object file directory">;
 defm thinlto_cache_policy: Eq<"thinlto-cache-policy", "Pruning policy for the ThinLTO cache">;