[llvm-branch-commits] [llvm] 25fefa5 - [RGT][TextAPI] Remove a zero-trip loop and the assertions within it

[Paul Robinson via llvm-branch-commits]

Author: Paul Robinson
Date: 2021-01-22T15:07:41-08:00
New Revision: 25fefa5a098e958888496735f793fd01f3e82874

URL: https://github.com/llvm/llvm-project/commit/25fefa5a098e958888496735f793fd01f3e82874
DIFF: https://github.com/llvm/llvm-project/commit/25fefa5a098e958888496735f793fd01f3e82874.diff

LOG: [RGT][TextAPI] Remove a zero-trip loop and the assertions within it

Found by the Rotten Green Tests project.

Differential Revision: https://reviews.llvm.org/D95259

Added: 
    

Modified: 
    llvm/unittests/TextAPI/TextStubV4Tests.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/TextAPI/TextStubV4Tests.cpp b/llvm/unittests/TextAPI/TextStubV4Tests.cpp
index 0ab9c524073f..403e2d691e52 100644
--- a/llvm/unittests/TextAPI/TextStubV4Tests.cpp
+++ b/llvm/unittests/TextAPI/TextStubV4Tests.cpp
@@ -255,18 +255,9 @@ TEST(TBDv4, ReadMultipleDocuments) {
                             {Targets[0], Targets[2]});
   EXPECT_EQ(1U, File->reexportedLibraries().size());
   EXPECT_EQ(reexport, File->reexportedLibraries().front());
-  ExportedSymbolSeq Exports;
-  for (const auto *Sym : File->symbols()) {
-    EXPECT_FALSE(Sym->isWeakReferenced());
-    EXPECT_FALSE(Sym->isUndefined());
-    Exports.emplace_back(ExportedSymbol{Sym->getKind(), Sym->getName().str(),
-                                        Sym->isWeakDefined(),
-                                        Sym->isThreadLocalValue()});
-  }
-  EXPECT_EQ(0U, Exports.size());
+  EXPECT_TRUE(File->symbols().empty());
 
   // Check Inlined Document
-  Exports.clear();
   Targets.clear();
   Uuids.clear();
   PlatformKind Platform = PlatformKind::macOS;
@@ -292,6 +283,7 @@ TEST(TBDv4, ReadMultipleDocuments) {
   EXPECT_TRUE(Document->isApplicationExtensionSafe());
   EXPECT_FALSE(Document->isInstallAPI());
 
+  ExportedSymbolSeq Exports;
   ExportedSymbolSeq Reexports, Undefineds;
   for (const auto *Sym : Document->symbols()) {
     ExportedSymbol Temp =