[llvm-branch-commits] [llvm] c6e8f81 - [llvm-mca] Addressing build failures due to missing override specifiers

[Wolfgang Pieb via llvm-branch-commits]

Author: Wolfgang Pieb
Date: 2021-01-21T17:32:18-08:00
New Revision: c6e8f81410a2942b5abd112aa6e468268e01d946

URL: https://github.com/llvm/llvm-project/commit/c6e8f81410a2942b5abd112aa6e468268e01d946
DIFF: https://github.com/llvm/llvm-project/commit/c6e8f81410a2942b5abd112aa6e468268e01d946.diff

LOG: [llvm-mca] Addressing build failures due to missing override specifiers

Added: 
    

Modified: 
    llvm/tools/llvm-mca/Views/InstructionInfoView.cpp
    llvm/tools/llvm-mca/Views/InstructionInfoView.h
    llvm/tools/llvm-mca/Views/ResourcePressureView.h
    llvm/tools/llvm-mca/Views/TimelineView.h

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-mca/Views/InstructionInfoView.cpp b/llvm/tools/llvm-mca/Views/InstructionInfoView.cpp
index bff5729bbc96..2248f63fe7e9 100644
--- a/llvm/tools/llvm-mca/Views/InstructionInfoView.cpp
+++ b/llvm/tools/llvm-mca/Views/InstructionInfoView.cpp
@@ -141,7 +141,7 @@ json::Value InstructionInfoView::toJSON() const {
   collectData(IIVD);
 
   json::Array InstInfo;
-  for (const auto I : enumerate(IIVD)) {
+  for (const auto &I : enumerate(IIVD)) {
     const InstructionInfoViewData &IIVDEntry = I.value();
     json::Object JO = toJSON(IIVDEntry);
     JO.try_emplace("Instruction", (unsigned)I.index());

diff  --git a/llvm/tools/llvm-mca/Views/InstructionInfoView.h b/llvm/tools/llvm-mca/Views/InstructionInfoView.h
index 82b2d678ea6b..5d52164e2d50 100644
--- a/llvm/tools/llvm-mca/Views/InstructionInfoView.h
+++ b/llvm/tools/llvm-mca/Views/InstructionInfoView.h
@@ -78,7 +78,7 @@ class InstructionInfoView : public InstructionView {
 
   void printView(llvm::raw_ostream &OS) const override;
   StringRef getNameAsString() const override { return "InstructionInfoView"; }
-  json::Value toJSON() const;
+  json::Value toJSON() const override;
   json::Object toJSON(const InstructionInfoViewData &IIVD) const;
 };
 } // namespace mca

diff  --git a/llvm/tools/llvm-mca/Views/ResourcePressureView.h b/llvm/tools/llvm-mca/Views/ResourcePressureView.h
index 5a9b5caee503..c3993a08c170 100644
--- a/llvm/tools/llvm-mca/Views/ResourcePressureView.h
+++ b/llvm/tools/llvm-mca/Views/ResourcePressureView.h
@@ -95,7 +95,7 @@ class ResourcePressureView : public InstructionView {
     printResourcePressurePerInst(OS);
   }
   StringRef getNameAsString() const override { return "ResourcePressureView"; }
-  json::Value toJSON() const;
+  json::Value toJSON() const override;
 };
 } // namespace mca
 } // namespace llvm

diff  --git a/llvm/tools/llvm-mca/Views/TimelineView.h b/llvm/tools/llvm-mca/Views/TimelineView.h
index a9e94d7b2a92..81f2b0335081 100644
--- a/llvm/tools/llvm-mca/Views/TimelineView.h
+++ b/llvm/tools/llvm-mca/Views/TimelineView.h
@@ -180,7 +180,7 @@ class TimelineView : public InstructionView {
     printAverageWaitTimes(OS);
   }
   StringRef getNameAsString() const override { return "TimelineView"; }
-  json::Value toJSON() const;
+  json::Value toJSON() const override;
 };
 } // namespace mca
 } // namespace llvm