[llvm-branch-commits] [llvm] 1e11402 - [llvm-readobj] - Add 'override' to fix build bots.

Georgii Rymar via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Tue Jan 12 02:05:55 PST 2021


Author: Georgii Rymar
Date: 2021-01-12T13:01:15+03:00
New Revision: 1e11402aa8e25d88c095a1c70fc87d2d9775186b

URL: https://github.com/llvm/llvm-project/commit/1e11402aa8e25d88c095a1c70fc87d2d9775186b
DIFF: https://github.com/llvm/llvm-project/commit/1e11402aa8e25d88c095a1c70fc87d2d9775186b.diff

LOG: [llvm-readobj] - Add 'override' to fix build bots.

This should fix bots after landing D93900.

An example of error is:

/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/llvm/tools/llvm-readobj/ELFDumper.cpp:883:8: warning: 'printSectionMapping' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  void printSectionMapping() {}

Added: 
    

Modified: 
    llvm/tools/llvm-readobj/ELFDumper.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp
index a09ee6d630d7..44608b8c9a06 100644
--- a/llvm/tools/llvm-readobj/ELFDumper.cpp
+++ b/llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -831,8 +831,8 @@ template <typename ELFT> class GNUELFDumper : public ELFDumper<ELFT> {
 
   std::string getSymbolSectionNdx(const Elf_Sym &Symbol,
                                   unsigned SymIndex) const;
-  void printProgramHeaders();
-  void printSectionMapping();
+  void printProgramHeaders() override;
+  void printSectionMapping() override;
   void printGNUVersionSectionProlog(const typename ELFT::Shdr &Sec,
                                     const Twine &Label, unsigned EntriesNum);
 
@@ -879,8 +879,8 @@ template <typename ELFT> class LLVMELFDumper : public ELFDumper<ELFT> {
   void printSymbol(const Elf_Sym &Symbol, unsigned SymIndex,
                    Optional<StringRef> StrTable, bool IsDynamic,
                    bool /*NonVisibilityBitsUsed*/) const override;
-  void printProgramHeaders();
-  void printSectionMapping() {}
+  void printProgramHeaders() override;
+  void printSectionMapping() override {}
   void printStackSizeEntry(uint64_t Size, StringRef FuncName) override;
 
   void printMipsGOT(const MipsGOTParser<ELFT> &Parser) override;


        


More information about the llvm-branch-commits mailing list