[llvm-branch-commits] [llvm] c3673ea - [llvm-readobj] - Fix a warning.

[Georgii Rymar via llvm-branch-commits]

Author: Georgii Rymar
Date: 2020-11-26T10:24:24+03:00
New Revision: c3673ea65df576535c85397dfe36624bd09fe47b

URL: https://github.com/llvm/llvm-project/commit/c3673ea65df576535c85397dfe36624bd09fe47b
DIFF: https://github.com/llvm/llvm-project/commit/c3673ea65df576535c85397dfe36624bd09fe47b.diff

LOG: [llvm-readobj] - Fix a warning.

This addresses post review comment for D92018.

The warning was:

```
error: loop variable 'Note' is always a copy because the range of type 'iterator_range<llvm::object::ELFFile<llvm::object::ELFType<llvm::support::big, true> >::Elf_Note_Iterator>' (aka 'iterator_range<Elf_Note_Iterator_Impl<ELFType<(llvm::support::endianness)0U, true> > >') does not return a reference [-Werror,-Wrange-loop-analysis]
      for (const typename ELFT::Note &Note : Obj.notes(S, Err))
```

Added: 
    

Modified: 
    llvm/tools/llvm-readobj/ELFDumper.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-readobj/ELFDumper.cpp b/llvm/tools/llvm-readobj/ELFDumper.cpp
index 2fac1c970fb3..656b9924ece0 100644
--- a/llvm/tools/llvm-readobj/ELFDumper.cpp
+++ b/llvm/tools/llvm-readobj/ELFDumper.cpp
@@ -5559,7 +5559,7 @@ static void printNotesHelper(
       StartNotesFn(expectedToOptional(Obj.getSectionName(S)), S.sh_offset,
                    S.sh_size);
       Error Err = Error::success();
-      for (const typename ELFT::Note &Note : Obj.notes(S, Err))
+      for (const typename ELFT::Note Note : Obj.notes(S, Err))
         ProcessNoteFn(Note);
       if (Err)
         Dumper.reportUniqueWarning(