[llvm-branch-commits] [llvm] 913a99c - [BasicAA] Remove stale FIXME (NFC)

[Nikita Popov via llvm-branch-commits]

Author: Nikita Popov
Date: 2020-11-21T20:07:26+01:00
New Revision: 913a99c47439740531e03cc7d08fc04448c0752c

URL: https://github.com/llvm/llvm-project/commit/913a99c47439740531e03cc7d08fc04448c0752c
DIFF: https://github.com/llvm/llvm-project/commit/913a99c47439740531e03cc7d08fc04448c0752c.diff

LOG: [BasicAA] Remove stale FIXME (NFC)

If aliasGEP returns MayAlias, the code does fall through to
aliasPHI etc, so this FIXME is no longer applicable.

Added: 
    

Modified: 
    llvm/lib/Analysis/BasicAliasAnalysis.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/BasicAliasAnalysis.cpp b/llvm/lib/Analysis/BasicAliasAnalysis.cpp
index 944ff8e9917b..c7736e758bd1 100644
--- a/llvm/lib/Analysis/BasicAliasAnalysis.cpp
+++ b/llvm/lib/Analysis/BasicAliasAnalysis.cpp
@@ -1746,8 +1746,6 @@ AliasResult BasicAAResult::aliasCheck(const Value *V1, LocationSize V1Size,
   if (!Pair.second)
     return Pair.first->second;
 
-  // FIXME: This isn't aggressively handling alias(GEP, PHI) for example: if the
-  // GEP can't simplify, we don't even look at the PHI cases.
   if (const GEPOperator *GV1 = dyn_cast<GEPOperator>(V1)) {
     AliasResult Result =
         aliasGEP(GV1, V1Size, V1AAInfo, V2, V2Size, V2AAInfo, O1, O2, AAQI);