[llvm-branch-commits] [llvm] 3dee8be - llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable

Hans Wennborg via llvm-branch-commits llvm-branch-commits at lists.llvm.org
Wed Feb 19 04:19:44 PST 2020


Author: Cristian Adam
Date: 2020-02-19T13:16:17+01:00
New Revision: 3dee8be1c3fe621b9c1926658f6c0df72ce804be

URL: https://github.com/llvm/llvm-project/commit/3dee8be1c3fe621b9c1926658f6c0df72ce804be
DIFF: https://github.com/llvm/llvm-project/commit/3dee8be1c3fe621b9c1926658f6c0df72ce804be.diff

LOG: llvm: Use quotes around MSVC_DIA_SDK_DIR CMake variable

MSVC_DIA_SDK_DIR variable will point to a path which contains spaces,
and without quotes it will fail to configure the project.

(cherry picked from commit d6fe253653b7e760f94ca21d0a7ebbfeeee28777)

Added: 
    

Modified: 
    llvm/cmake/config-ix.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/config-ix.cmake b/llvm/cmake/config-ix.cmake
index a16038f70989..fc66dbfcbe7a 100644
--- a/llvm/cmake/config-ix.cmake
+++ b/llvm/cmake/config-ix.cmake
@@ -469,7 +469,7 @@ if( MSVC )
   # though that we should handle it.  We do so by simply checking that
   # the DIA SDK folder exists.  Should this happen you will need to
   # uninstall VS 2012 and then re-install VS 2013.
-  if (IS_DIRECTORY ${MSVC_DIA_SDK_DIR})
+  if (IS_DIRECTORY "${MSVC_DIA_SDK_DIR}")
     set(HAVE_DIA_SDK 1)
   else()
     set(HAVE_DIA_SDK 0)


        


More information about the llvm-branch-commits mailing list