[llvm-branch-commits] [clang-tools-extra] cbec01f - [clangd] Add workaround for GCC5 host compilers. NFC.

[Hans Wennborg via llvm-branch-commits]

Author: Michael Liao
Date: 2020-02-06T10:24:11+01:00
New Revision: cbec01fe05895abe96f2cb80e24367dec60209ee

URL: https://github.com/llvm/llvm-project/commit/cbec01fe05895abe96f2cb80e24367dec60209ee
DIFF: https://github.com/llvm/llvm-project/commit/cbec01fe05895abe96f2cb80e24367dec60209ee.diff

LOG: [clangd] Add workaround for GCC5 host compilers. NFC.

(cherry picked from commit 40514a7d7a3b745ba43c2d014e54a0d78d65d957)

Added: 
    

Modified: 
    clang-tools-extra/clangd/Hover.cpp

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp
index 754baf26568f..834c9d041872 100644
--- a/clang-tools-extra/clangd/Hover.cpp
+++ b/clang-tools-extra/clangd/Hover.cpp
@@ -447,7 +447,13 @@ bool isLiteral(const Expr *E) {
 
 llvm::StringLiteral getNameForExpr(const Expr *E) {
   // FIXME: Come up with names for `special` expressions.
-  return "expression";
+  //
+  // It's an known issue for GCC5, https://godbolt.org/z/Z_tbgi. Work around
+  // that by using explicit conversion constructor.
+  //
+  // TODO: Once GCC5 is fully retired and not the minimal requirement as stated
+  // in `GettingStarted`, please remove the explicit conversion constructor.
+  return llvm::StringLiteral("expression");
 }
 
 // Generates hover info for evaluatable expressions.