[llvm-branch-commits] [llvm] a90b42b - [ThinLTO] Default -enable-import-metadata to false

[Fangrui Song via llvm-branch-commits]

Author: Fangrui Song
Date: 2020-12-31T10:04:21-08:00
New Revision: a90b42b0fec618124a3ed573ecd0e192a61815f7

URL: https://github.com/llvm/llvm-project/commit/a90b42b0fec618124a3ed573ecd0e192a61815f7
DIFF: https://github.com/llvm/llvm-project/commit/a90b42b0fec618124a3ed573ecd0e192a61815f7.diff

LOG: [ThinLTO] Default -enable-import-metadata to false

The default value is dependent on `-DLLVM_ENABLE_ASSERTIONS={off,on}` (D22167), which is
error-prone. The few tests checking `!thinlto_src_module` can specify -enable-import-metadata explicitly.

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D93959

Added: 
    

Modified: 
    llvm/lib/Transforms/IPO/FunctionImport.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/IPO/FunctionImport.cpp b/llvm/lib/Transforms/IPO/FunctionImport.cpp
index 3015a5f8ee37..18343030bc6a 100644
--- a/llvm/lib/Transforms/IPO/FunctionImport.cpp
+++ b/llvm/lib/Transforms/IPO/FunctionImport.cpp
@@ -124,14 +124,8 @@ static cl::opt<bool> ComputeDead("compute-dead", cl::init(true), cl::Hidden,
                                  cl::desc("Compute dead symbols"));
 
 static cl::opt<bool> EnableImportMetadata(
-    "enable-import-metadata", cl::init(
-#if !defined(NDEBUG)
-                                  true /*Enabled with asserts.*/
-#else
-                                  false
-#endif
-                                  ),
-    cl::Hidden, cl::desc("Enable import metadata like 'thinlto_src_module'"));
+    "enable-import-metadata", cl::init(false), cl::Hidden,
+    cl::desc("Enable import metadata like 'thinlto_src_module'"));
 
 /// Summary file to use for function importing when using -function-import from
 /// the command line.