[llvm-branch-commits] [lldb] e7a3c4c - [lldb-vscode] Speculative fix for raciness in TestVSCode_attach
Pavel Labath via llvm-branch-commits
llvm-branch-commits at lists.llvm.org
Thu Dec 17 05:24:39 PST 2020
Author: Pavel Labath
Date: 2020-12-17T14:19:52+01:00
New Revision: e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5
URL: https://github.com/llvm/llvm-project/commit/e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5
DIFF: https://github.com/llvm/llvm-project/commit/e7a3c4c11e84ba99c3682ae6cf20c398f16cf3f5.diff
LOG: [lldb-vscode] Speculative fix for raciness in TestVSCode_attach
The test appears to expect the inferior to be stopped, but the custom
"attach commands" leave it in a running state.
It's unclear how this could have ever worked.
Added:
Modified:
lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py
Removed:
################################################################################
diff --git a/lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py b/lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py
index 7955b6a97b04..aa7a3ae17cb0 100644
--- a/lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py
+++ b/lldb/test/API/tools/lldb-vscode/attach/TestVSCode_attach.py
@@ -145,7 +145,7 @@ def test_commands(self):
# and use it for debugging
attachCommands = [
'target create -d "%s"' % (program),
- 'process launch'
+ 'process launch --stop-at-entry'
]
initCommands = ['target list', 'platform list']
preRunCommands = ['image list a.out', 'image dump sections a.out']
More information about the llvm-branch-commits
mailing list